feat: add Snell's Law refraction angle calculation#14623
Open
soradacroi wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
feat: add Snell's Law refraction angle calculation#14623soradacroi wants to merge 1 commit intoTheAlgorithms:masterfrom
soradacroi wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Added snells_law.py to the physics/ directory.
This implements the calculate_refraction_angle function,
which finds the refraction angle based on Snell's Law.
The implementation handles standard refraction, the critical angle (90°), Total Internal Reflection (TIR)
and Validation logic to catch physically impossible inputs (refractive index ratios less than -1).
Checklist: