Skip to content

feat: add Snell's Law refraction angle calculation#14623

Open
soradacroi wants to merge 1 commit intoTheAlgorithms:masterfrom
soradacroi:snells_law
Open

feat: add Snell's Law refraction angle calculation#14623
soradacroi wants to merge 1 commit intoTheAlgorithms:masterfrom
soradacroi:snells_law

Conversation

@soradacroi
Copy link
Copy Markdown

@soradacroi soradacroi commented May 3, 2026

Describe your change:

Added snells_law.py to the physics/ directory.
This implements the calculate_refraction_angle function,
which finds the refraction angle based on Snell's Law.

The implementation handles standard refraction, the critical angle (90°), Total Internal Reflection (TIR)
and Validation logic to catch physically impossible inputs (refractive index ratios less than -1).

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Add or change doctests? -- Note: Please avoid changing both code and tests in a single pull request.
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new Python files are placed inside an existing directory.
  • All filenames are in all lowercase characters with no spaces or dashes.
  • All functions and variable names follow Python naming conventions.
  • All function parameters and return values are annotated with Python type hints.
  • All functions have doctests that pass the automated testing.
  • All new algorithms include at least one URL that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the description above includes the issue number(s) with a closing keyword: "Fixes #ISSUE-NUMBER".

@algorithms-keeper algorithms-keeper Bot added the awaiting reviews This PR is ready to be reviewed label May 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting reviews This PR is ready to be reviewed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant