refactor: improve type hints in linear_search.py (v2)#14619
Open
jlaportebot wants to merge 1 commit intoTheAlgorithms:masterfrom
Open
refactor: improve type hints in linear_search.py (v2)#14619jlaportebot wants to merge 1 commit intoTheAlgorithms:masterfrom
jlaportebot wants to merge 1 commit intoTheAlgorithms:masterfrom
Conversation
- Changed sequence parameter from list to list[Any] for better type specificity - Changed target parameter from int to Any for better flexibility - Added typing import for Any type - This allows the functions to work with any comparable types, not just integers - All existing doctests pass - Type checking with mypy passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your change:
Improved type hints in linear_search.py to be more specific and flexible while maintaining backward compatibility.
Checklist:
Changes Made
Type Hint Improvements
linear_search function:
sequence: listtosequence: list[Any]for better type specificitytarget: inttotarget: Anyfor better flexibilityfrom typing import Anyimportrec_linear_search function:
sequence: listtosequence: list[Any]for better type specificitytarget: inttotarget: Anyfor better flexibilityBenefits
list[Any]is more specific thanlistwhile maintaining flexibilityTesting
Why This Approach
The previous PR (#14614) was closed because the checklist was not properly completed. This PR:
This is a follow-up to the closed PR #14614, with proper checklist completion.