feat: add binary search on answer template with example use case#14582
feat: add binary search on answer template with example use case#14582meenaksh06 wants to merge 5 commits intoTheAlgorithms:masterfrom
Conversation
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
|
|
||
| def can_ship(capacity: int) -> bool: | ||
| days_used = 1 | ||
| current = 0 |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/binary_search_on_answers.py, please provide doctest for the function can_ship
There was a problem hiding this comment.
Click here to look at the relevant links ⬇️
🔗 Relevant Links
Repository:
Python:
Automated review generated by algorithms-keeper. If there's any problem regarding this review, please open an issue about it.
algorithms-keeper commands and options
algorithms-keeper actions can be triggered by commenting on this PR:
@algorithms-keeper reviewto trigger the checks for only added pull request files@algorithms-keeper review-allto trigger the checks for all the pull request files, including the modified files. As we cannot post review comments on lines not part of the diff, this command will post all the messages in one comment.NOTE: Commands are in beta and so this feature is restricted only to a member or owner of the organization.
| 15 | ||
| """ | ||
|
|
||
| def can_ship(capacity: int) -> bool: |
There was a problem hiding this comment.
As there is no test file in this pull request nor any test function or class in the file searches/binary_search_on_answers.py, please provide doctest for the function can_ship
|
Happy to make any improvements if needed. Thanks for reviewing! |
|
Please take a look over it, let me know it if any changes have to be done. |
Describe your change:
Improved the existing Binary Search on Answer implementation by:
These changes improve reliability and make the implementation easier to understand and verify.
Checklist: