chore(publish): strip iocraft download/publish pipeline#1294
Open
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Open
chore(publish): strip iocraft download/publish pipeline#1294John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
John-David Dalton (jdalton) wants to merge 1 commit intomainfrom
Conversation
The @socketaddon/iocraft* packages now publish from a dedicated repo
(SocketDev/socket-addon). socket-cli's role narrows to *consuming*
@socketaddon/iocraft as a runtime dep — it no longer downloads .node
binaries from socket-btm or republishes them to npm.
Removed:
- scripts/download-iocraft-binaries.mts
- packages/package-builder/scripts/publish-socketaddon-placeholders.mts
- packages/package-builder/scripts/PUBLISHING-PLACEHOLDERS.md
- packages/package-builder/test-iocraft-package.mts
Edited .github/workflows/provenance.yml:
- removed the 'iocraft' workflow_dispatch input
- removed the iocraft version/tag computation in the 'Get versions' step
- removed the four iocraft steps (Download binaries, Copy binaries,
Publish main, Publish platform packages)
- removed the iocraft branches in the Summary step
Net change: 1088 lines deleted, 1 added.
Dev plumbing (templates/socketaddon-{main,package}/, generate-socketaddon-
packages.mts, setup-iocraft-dev.mts, the cli/package.json `file:` link to
the dev build dir, the CI shim heredocs in ci.yml, the iocraft test
exclusion list in vitest.config.mts) is intentionally untouched —
socket-cli still needs @socketaddon/iocraft installable at install time
for tests + dev. The follow-up commit replaces the `file:` link with a
registry version once SocketDev/socket-addon publishes a real version.
Pre-commit tests skipped (DISABLE_PRECOMMIT_TEST=1) — the iocraft
renderer tests require a real native iocraft.node which this worktree
doesn't have. CI excludes those same tests via vitest.config.mts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the iocraft download/publish pipeline from socket-cli. Going forward,
@socketaddon/iocraft*packages publish from the dedicatedSocketDev/socket-addonrepo. socket-cli's role narrows to consuming@socketaddon/iocraftas a runtime dep.This is part 1 of 2:
cli/package.json's\"@socketaddon/iocraft\": \"file:...\"for the registry version, oncesocket-addonpublishes a real version.Removed
scripts/download-iocraft-binaries.mtspackages/package-builder/scripts/publish-socketaddon-placeholders.mtspackages/package-builder/scripts/PUBLISHING-PLACEHOLDERS.mdpackages/package-builder/test-iocraft-package.mtsEdited
.github/workflows/provenance.yml:iocraft:workflow_dispatch inputNet change: 1088 lines deleted, 1 added.
Intentionally untouched
Dev plumbing remains in place because socket-cli still needs
@socketaddon/iocraftinstallable for tests + dev:packages/package-builder/templates/socketaddon-{main,package}/packages/package-builder/scripts/generate-socketaddon-packages.mtspackages/cli/scripts/setup-iocraft-dev.mts,test-iocraft-layout.mtspackages/cli/package.json'sfile:link to the dev build dir.github/workflows/ci.ymlshim heredocspackages/cli/vitest.config.mtsiocraft-test exclusion listThe follow-up PR replaces the
file:link with a registry version and removes most of these.Test plan
vitest.config.mtswhenCI=true)iocraftcheckbox under workflow_dispatchpnpm installresolves@socketaddon/iocraftfrom the devfile:link (unchanged)Migration sequence
After this lands and
SocketDev/socket-addonpublishes its first non-0.0.0version:SocketDev/socket-addonas the trusted publisher for each@socketaddon/iocraft*package on npmSocketDev/socket-clias the trusted publisher for eachfile:link for the registry version