feat(scan): expose --reach-continue-on-* flags in help#1293
Merged
Martin Torp (mtorp) merged 2 commits intov1.xfrom May 1, 2026
Merged
feat(scan): expose --reach-continue-on-* flags in help#1293Martin Torp (mtorp) merged 2 commits intov1.xfrom
Martin Torp (mtorp) merged 2 commits intov1.xfrom
Conversation
Now that Coana v15 is the default, surface the four reach-continue-on flags in `socket scan create --help` and `socket scan reach --help` so users can discover and use them. Bumps the CLI to 1.1.91.
Benjamin Barslev Nielsen (barslev)
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hidden: truefrom the four--reach-continue-on-*flags insrc/commands/scan/reachability-flags.mtsso they show up insocket scan create --helpandsocket scan reach --help.cmd-scan-create.test.mtsandcmd-scan-reach.test.mtsto include the now-visible flag lines.1.1.91and adds aChangedentry to the changelog.The flags themselves were added in #1251 as hidden until Coana v15 became the default; v15 is now the default (#1289), so they can be surfaced.
Test plan
npx vitest run src/commands/scan/cmd-scan-create.test.mts src/commands/scan/cmd-scan-reach.test.mts— 79 passedpnpm check:tsc— cleanpnpm check:lintfor the touched files — clean (pre-existing errors elsewhere unrelated to this change)Note
Low Risk
Low risk: this mostly surfaces previously-hidden reachability flags in CLI help and updates test snapshots, with a routine version/changelog bump and no change to scan execution logic.
Overview
Surfaces four reachability resilience flags (the
--reach-continue-on-*options) insocket scan createandsocket scan reachhelp output by un-hiding them inreachability-flags.mts.Updates the help snapshot tests to include the newly-visible flag lines, and bumps the CLI version to
1.1.91with a correspondingCHANGELOG.mdentry.Reviewed by Cursor Bugbot for commit 6c775c8. Configure here.