[Tests] Replace filesystem mocks with real temporary directory in Notifier tests#7441
[Tests] Replace filesystem mocks with real temporary directory in Notifier tests#7441gonzaloriestra wants to merge 1 commit intomainfrom
Conversation
…ifier tests
Replaces brittle `vi.mock('fs/promises')` usage with `inTemporaryDirectory` and real file assertions in `packages/theme/src/cli/utilities/notifier.test.ts`. This aligns with the project's test quality standards by testing actual behavior rather than implementation details (spies).
Improvements:
- Uses `inTemporaryDirectory` to provide a real, isolated filesystem environment for tests.
- Replaces `expect(fs.writeFile).toHaveBeenCalledWith` with `expect(await readFile(path)).toBe(fileName)` to verify actual side effects.
- Triggers real filesystem errors in error-path tests by using non-existent paths instead of manual mock rejections.
- Removes unused mock assertions for `fs.appendFile`.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
1 participant
This PR improves the test quality of
notifier.test.tsby replacing filesystem mocks with real filesystem interactions using temporary directories.Specifically:
vi.mock('fs/promises').inTemporaryDirectoryandreadFilefrom@shopify/cli-kit/node/fs.fs.appendFile.These changes make the tests more robust against implementation details and ensure they are testing actual behavior in a deterministic, isolated environment.
PR created automatically by Jules for task 6840211217554415176 started by @gonzaloriestra