macOS: Set ns_window to the parent window when creating WindowHandles#238
Merged
macOS: Set ns_window to the parent window when creating WindowHandles#238
Conversation
Contributor
|
Tested both examples and can confirm it is not crashing anymore 👍 Mac Studio M1 Max |
Member
Author
|
@dathinaios Sweet! Thank you for taking the time to test it ^^ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, when baseview creates a window in parented mode, the
WindowHandles it gives out have theirns_windowfield set tonull, which makes some downstream libraries (such assoftbuffer) crash.This means the
open_parentedexample completely crashes as a result, it does not even start properly on macOS.This PR fixes this by storing the parent
NSWindowpointer separately, and then using it to set theWindowHandle'sns_windowfield.I can confirm it prevents the crash on macOS 26.2.
This PR supersedes the fix in #219. Unlike in that PR, this PR stores the parent
NSWindowpointer separately, so it does not impact other baseview operations.