Win32: Better DPI changes handling#235
Merged
prokopyl merged 3 commits intoRustAudio:masterfrom May 3, 2026
Merged
Conversation
b0bb0d2 to
f9af5e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improves the Win32 DPI changes handling in several ways:
current_sizeandcurrent_scale_factor, allowing us to track which one changed;Cells instead ofRefCell;RECTgiven with the event;This is a leaner version of #178, leaving the more "refactor-y" parts of it for later.
Note that there are still some DPI-related issues even after this PR, but they require some larger refactoring and usage of DPI-aware Win32 functions (e.g.
AdjustWindowRectExForDpi,SetThreadDpiAwarenessContext, etc.), so we'll do these after the v0.1 release.