Skip to content

Add smart for k230d#11359

Open
BernardXiong wants to merge 4 commits intoRT-Thread:masterfrom
BernardXiong:smart_k230d
Open

Add smart for k230d#11359
BernardXiong wants to merge 4 commits intoRT-Thread:masterfrom
BernardXiong:smart_k230d

Conversation

@BernardXiong
Copy link
Copy Markdown
Member

拉取/合并请求描述:(PR description)

[

为什么提交这份PR (why to submit this PR)

在K230 BSP中加入smart对K230D芯片的支持;

你的解决方案是什么 (what is your solution)

加入SOC_K230/SOC_K230D的配置宏,with deepseek v4 pro.

请提供验证的bsp和config (provide the config and bsp)

  • BSP:
    K230
  • .config:
  • action:

]

当前拉取/合并请求的状态 Intent for your PR

必须选择一项 Choose one (Mandatory):

  • 本拉取/合并请求是一个草稿版本 This PR is for a code-review and is intended to get feedback
  • 本拉取/合并请求是一个成熟版本 This PR is mature, and ready to be integrated into the repo

代码质量 Code Quality:

我在这个拉取/合并请求中已经考虑了 As part of this pull request, I've considered the following:

  • 已经仔细查看过代码改动的对比 Already check the difference between PR and old code
  • 代码风格正确,包括缩进空格,命名及其他风格 Style guide is adhered to, including spacing, naming and other styles
  • 没有垃圾代码,代码尽量精简,不包含#if 0代码,不包含已经被注释了的代码 All redundant code is removed and cleaned up
  • 所有变更均有原因及合理的,并且不会影响到其他软件组件代码或BSP All modifications are justified and not affect other components or BSP
  • 对难懂代码均提供对应的注释 I've commented appropriately where code is tricky
  • 代码是高质量的 Code in this PR is of high quality
  • 已经使用formatting 等源码格式化工具确保格式符合RT-Thread代码规范 This PR complies with RT-Thread code specification
  • 如果是新增bsp, 已经添加ci检查到.github/ALL_BSP_COMPILE.json 详细请参考链接BSP自查

Introduce a Kconfig choice between SOC_K230 and SOC_K230D to support
different chip variants. SOC_K230D targets the ATK-DNK230D board with
128MB DDR, while SOC_K230 serves as the default for other K230 boards.

Key changes:
- Replace single BOARD_C908 config with a choice menu for SoC variant
- Move common selects (ARCH_RISCV64, RT_USING_CACHE, ARCH_MM_MMU, etc.)
  into each SoC config entry
- Add ARCH_RISCV_XUANTIE select for Xuantie processor support
- mem_layout.h: define per-SoC default memory sizes with #if defined()
  blocks, add #error guard when no SoC is selected
- Fix typo: Kerenl -> Kernel in memory layout ASCII diagram

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

👋 感谢您对 RT-Thread 的贡献!Thank you for your contribution to RT-Thread!

为确保代码符合 RT-Thread 的编码规范,请在你的仓库中执行以下步骤运行代码格式化工作流(如果格式化CI运行失败)。
To ensure your code complies with RT-Thread's coding style, please run the code formatting workflow by following the steps below (If the formatting of CI fails to run).


🛠 操作步骤 | Steps

  1. 前往 Actions 页面 | Go to the Actions page
    点击进入工作流 → | Click to open workflow →

  2. 点击 Run workflow | Click Run workflow

  • 设置需排除的文件/目录(目录请以"/"结尾)
    Set files/directories to exclude (directories should end with "/")
  • 将目标分支设置为 \ Set the target branch to:smart_k230d
  • 设置PR number为 \ Set the PR number to:11359
  1. 等待工作流完成 | Wait for the workflow to complete
    格式化后的代码将自动推送至你的分支。
    The formatted code will be automatically pushed to your branch.

完成后,提交将自动更新至 smart_k230d 分支,关联的 Pull Request 也会同步更新。
Once completed, commits will be pushed to the smart_k230d branch automatically, and the related Pull Request will be updated.

如有问题欢迎联系我们,再次感谢您的贡献!💐
If you have any questions, feel free to reach out. Thanks again for your contribution!

@github-actions github-actions Bot added BSP Arch: RISC-V BSP related with risc-v libcpu labels May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

📌 Code Review Assignment

🏷️ Tag: bsp_k230

Reviewers: unicornx

Changed Files (Click to expand)
  • bsp/k230/Kconfig
  • bsp/k230/board/board.c
  • bsp/k230/board/board.h
  • bsp/k230/board/mem_layout.h
  • bsp/k230/drivers/interdrv/rtc/drv_rtc.c

🏷️ Tag: libcpu_riscv

Reviewers: Yaochenger

Changed Files (Click to expand)
  • libcpu/risc-v/common64/mmu.c

📊 Current Review Status (Last Updated: 2026-05-04 23:13 CST)

  • Yaochenger Pending Review
  • unicornx Pending Review

📝 Review Instructions

  1. 维护者可以通过单击此处来刷新审查状态: 🔄 刷新状态
    Maintainers can refresh the review status by clicking here: 🔄 Refresh Status

  2. 确认审核通过后评论 LGTM/lgtm
    Comment LGTM/lgtm after confirming approval

  3. PR合并前需至少一位维护者确认
    PR must be confirmed by at least one maintainer before merging

ℹ️ 刷新CI状态操作需要具备仓库写入权限。
ℹ️ Refresh CI status operation requires repository Write permission.

BernardXiong and others added 3 commits May 4, 2026 23:08
board.h: Remove unused peripheral base address defines for blocks that
are not currently supported (SRAM, GSDMA, DECOMP, ISP, VPU, GPU, VO,
DSI, Audio, USB2, SDHC, BootROM, Security, DDRC, XIP Flash, etc.).
This reduces clutter and keeps only actively used hardware definitions.

board.c: Add DBG_TAG/DBG_LVL configuration to enable debug logging via
the ulog framework. Replace Chinese comments with English descriptions
for better upstream readability. Add LOG_I/LOG_D trace points in
primary_cpu_entry() and rt_hw_board_init() to aid bring-up debugging.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change LOG_I to LOG_D for the "rtc driver register OK" message to
reduce console noise during normal boot. Also remove the unnecessary
trailing newline character from the log message.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Kconfig: Introduce ARCH_RISCV_XUANTIE option for Xuantie-based SoCs
and CONFIG_XUANTIE_SVPBMT under RT_USING_SMART to enable Svpbmt
extension support used by the Xuantie C908 core.

mmu.c: Several improvements for MMU management:
- Add dcache flush after populating early page table entries to ensure
  they are visible to the MMU hardware before enabling address
  translation
- Handle the case where v2p translation fails during aspace switch for
  low physical addresses below KERNEL_VADDR_START, falling back to
  direct physical address (needed during early K230 bring-up)
- When ARCH_REMAP_KERNEL is enabled, set up an identity map guard for
  low physical memory during aspace switch to validate boot context
  liveness during the transition away from the early page table
- Fix pointer arithmetic in _init_region() with explicit rt_ubase_t
  casts to avoid potential type promotion issues

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Arch: RISC-V BSP related with risc-v BSP libcpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant