fix: correct array type casting for indexed event parameters in generated contract wrappers#2274
Open
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Open
fix: correct array type casting for indexed event parameters in generated contract wrappers#2274Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Dev10-sys wants to merge 2 commits intoLFDT-web3j:mainfrom
Conversation
…FDT-web3j#1994) Fixes issue LFDT-web3j#1994 where indexed array event parameters (e.g., bytes32[]) were incorrectly cast to �yte[] instead of List<byte[]>, leading to ClassCastException in generated Java wrappers. Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Signed-off-by: Dev10-sys <dev10.sys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where indexed array event parameters (like
bytes32[]) were generated with the wrong type in contract wrappers.They were being treated as
byte[], which caused runtime errors. Now they are correctly handled asList<byte[]>.Why is it needed?
Right now, events with array parameters can fail at runtime because of incorrect casting.
This change fixes that and makes sure array values are decoded properly.
Additional notes
bytes32[]handlingFixes #1994