fix: ensure maxPriorityFeePerGas does not exceed maxFeePerGas in DynamicEIP1559GasProvider#2264
Open
Dev10-sys wants to merge 3 commits intoLFDT-web3j:mainfrom
Open
Conversation
Dev10-sys
added a commit
to Dev10-sys/web3j
that referenced
this pull request
Apr 22, 2026
…der (LFDT-web3j#2264) Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
…micEIP1559GasProvider Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
…der (LFDT-web3j#2264) Signed-off-by: Dev10-sys <kalpanagola9897@gmail.com>
Dev10-sys
force-pushed
the
fix/eip1559-priority-fee-overflow-clean
branch
from
eaa1ed2 to
d87cd89
Compare
Signed-off-by: Dev10-sys <dev10.sys@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an edge case where maxPriorityFeePerGas could exceed maxFeePerGas due to inconsistent RPC results.
The fix ensures that maxFeePerGas is always greater than or equal to maxPriorityFeePerGas by introducing a high-water mark for the priority fee during calculation.
A unit test is added to cover this scenario and verify the fix.
Fixes #2225