Remove unused paths field from LinterContextProps and contentPaths prop from editors#3568
Open
jeremywiebe wants to merge 2 commits intomainfrom
Open
Remove unused paths field from LinterContextProps and contentPaths prop from editors#3568jeremywiebe wants to merge 2 commits intomainfrom
jeremywiebe wants to merge 2 commits intomainfrom
Conversation
…tProps and contentPaths prop from editors
Contributor
|
Size Change: -52 B (-0.01%) Total Size: 502 kB 📦 View Changed
ℹ️ View Unchanged
|
Contributor
🛠️ Item Splitting: No Changes ✅ |
Contributor
🗄️ Schema Change: No Changes ✅ |
Contributor
npm Snapshot: PublishedGood news!! We've packaged up the latest commit from this PR (f606da4) and published it to npm. You Example: pnpm add @khanacademy/perseus@PR3568If you are working in Khan Academy's frontend, you can run the below command. ./dev/tools/bump_perseus_version.ts -t PR3568If you are working in Khan Academy's webapp, you can run the below command. ./dev/tools/bump_perseus_version.js -t PR3568 |
jeremywiebe
requested review from
catandthemachines,
ivyolamit and
nishasy
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
While working with Ben today on some preview-related refactoring, we started asking what some of the LinterContext values were for. Well, turns out
pathsis completely unused. A few places set it, but no code looks at it, so we can remove it.This propogates out to the
contentPathsprops on theArticleEditor,EditorPage, andHintEditorcomponents.contentPathsis used to set uppathson linter contexts, but no client passes it down, and becausepathsis dead, there's no point leaving the prop here.Issue: LEMS-4083
Test plan:
pnpm testpnpm typecheckRun storybook and make sure the previews for EditorPage work!