feat(retail): add Vertex AI Search for commerce snippets#10252
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces Java code samples for Vertex AI Search for commerce, covering basic search, pagination, and offset functionalities, along with corresponding integration tests. The review feedback identifies several improvement opportunities: using getTotalSize() instead of getResultsCount() to ensure accurate result counts across pages, simplifying API response handling, and removing redundant output in the samples. Additionally, the feedback suggests optimizing resource management in test utilities by reusing service clients instead of recreating them within loops.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces Java code samples and integration tests for Vertex AI Search for commerce, covering basic search, pagination, and offset functionality. The feedback provided focuses on correcting an inaccurate description in the README, optimizing the POM file by leveraging the BOM for dependency management, and improving the efficiency and reliability of test utilities by reusing service clients and extending the indexing wait times to prevent flaky tests.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces Java code samples for Vertex AI Search for commerce, including implementations for basic search, pagination, and offset-based results. It also provides a comprehensive suite of integration tests and a utility class for managing test data. A review comment suggests increasing the retry limit in the test utility to ensure products are fully indexed before tests run, reducing potential flakiness.
|
LGTM |
|
Here is the summary of changes. You are about to add 3 region tags.
This comment is generated by snippet-bot.
|
Just checked the new test, all is looking good to me. |
Description
Fixes internal b/502616950
Note: Before submitting a pull request, please open an issue for discussion if you are not associated with Google.
Checklist
pom.xmlparent set to latestshared-configurationmvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory only