Conversation
mhlidd
added
type: enhancement
mhlidd
requested review from
PerfectSlayer and
mcculls
and removed request for
a team
…opagatorTelemetryTest
There was a problem hiding this comment.
The behavior is looking good. I would improve readability as baggage propagator is already a complex piece.
I had some other readability comment for the testing part but I could not figure how to put it in GH suggestions, so I appended a commit: c09e52e. Feel free to read / edit / drop it to your liking. It was to reduce the stream API usage to make the case more readable by introducing some refactoring.
mcculls
left a comment
mcculls
left a comment
There was a problem hiding this comment.
Same suggestion as Bruce wrt. the limitReached refactoring
…Propagator.java Co-authored-by: Bruce Bujon <PerfectSlayer@users.noreply.github.com>
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in Use ⏳ Processing |
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
3 participants
What Does This Do
Rename local variables/functions for inject metrics, and add metrics for extract.
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.