Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Extends
TagInitializationErrors.javato also tagexecutionErrorandtest exceptionsynthetic testcaseswith
dd_tags[test.final_status]=skip, unconditionally. Previously, only intermediateinitializationErrorretries were tagged.The tagging logic is refactored into a shared
tagSkiphelper that uses direct child element lookups(instead of
getElementsByTagName, which searches all descendants) and is idempotent - testcases alreadycarrying the property are left unchanged.
Motivation
executionErrorandtest exceptionare framework-level synthetic entries that never represent a realtest result. Without this change, Test Optimization treats them as genuine failures, producing noise in
the test results dashboard. Like
initializationErrorintermediates, they should be skipped so onlyreal test outcomes are surfaced.
Additional Notes
TagInitializationErrors.javatoTagSyntheticFailures.javaContributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: APMLP-1296
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.