Add spark.openlineage.appName tag to spark.application spans#11246
Draft
aboitreaud wants to merge 2 commits intomasterfrom
Draft
Add spark.openlineage.appName tag to spark.application spans#11246aboitreaud wants to merge 2 commits intomasterfrom
aboitreaud wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What Does This Do
Capture on the spans the OL job name. can be overriden in OL so we need to capture it and have it on the span
Motivation
OpenLineage names the application job using spark.openlineage.appName if set, falling back to spark.app.name otherwise.
The gap: when a user sets spark.openlineage.appName to something different from spark.app.name, OL uses that override as its job name but Datadog never reads that key — so job_name on the span = spark.app.name while OL's job name = spark.openlineage.appName. Correlation with our job_name attr breaks.
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any other useful labelsclose,fix, or any linking keywords when referencing an issueUse
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]
Note: Once your PR is ready to merge, add it to the merge queue by commenting
/merge./merge -ccancels the queue request./merge -f --reason "reason"skips all merge queue checks; please use this judiciously, as some checks do not run at the PR-level. For more information, see this doc.