Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ jobs:
name: Relative performance benchmarking
runs-on: ubuntu-latest

permissions:
contents: 'read'
id-token: 'write'

steps:
- uses: actions/checkout@v6

Expand All @@ -25,6 +29,13 @@ jobs:
distribution: 'temurin'
cache: 'gradle'

- name: Authenticate to GCP
uses: google-github-actions/auth@v3
with:
token_format: access_token
workload_identity_provider: 'projects/1038484894585/locations/global/workloadIdentityPools/github-wi-pool/providers/github-wi-provider'
service_account: 'dsp-artifact-registry-push@dsp-artifact-registry.iam.gserviceaccount.com'

# Run benchmark via JMH gradle plugin https://github.com/melix/jmh-gradle-plugin
- name: Run benchmark
run: |
Expand Down
30 changes: 28 additions & 2 deletions .github/workflows/build-test-and-publish.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,10 @@ on:

jobs:
build:
permissions:
contents: 'read'
id-token: 'write'

runs-on: ubuntu-latest

steps:
Expand All @@ -28,14 +32,22 @@ jobs:
java-version: '17'
distribution: 'temurin'
cache: 'gradle'

- name: Authenticate to GCP
uses: google-github-actions/auth@v3
with:
token_format: access_token
workload_identity_provider: 'projects/1038484894585/locations/global/workloadIdentityPools/github-wi-pool/providers/github-wi-provider'
service_account: 'dsp-artifact-registry-push@dsp-artifact-registry.iam.gserviceaccount.com'
- name: Build all projects without running tests
run: ./gradlew --build-cache build -x test

source-clear:
needs: [ build ]
runs-on: ubuntu-latest

permissions:
contents: 'read'
id-token: 'write'
steps:
- uses: actions/checkout@v6
- name: Set up JDK
Expand All @@ -44,7 +56,12 @@ jobs:
java-version: '17'
distribution: 'temurin'
cache: 'gradle'

- name: Authenticate to GCP
uses: google-github-actions/auth@v3
with:
token_format: access_token
workload_identity_provider: 'projects/1038484894585/locations/global/workloadIdentityPools/github-wi-pool/providers/github-wi-provider'
service_account: 'dsp-artifact-registry-push@dsp-artifact-registry.iam.gserviceaccount.com'
- name: SourceClear scan
env:
SRCCLR_API_TOKEN: ${{ secrets.SRCCLR_API_TOKEN }}
Expand All @@ -53,6 +70,9 @@ jobs:
unit-tests-and-sonarqube:
needs: [ build ]
runs-on: ubuntu-latest
permissions:
contents: 'read'
id-token: 'write'
steps:
- uses: actions/checkout@v6
# Needed by sonar to get the git history for the branch the PR will be merged into.
Expand All @@ -64,6 +84,12 @@ jobs:
java-version: '17'
distribution: 'temurin'
cache: 'gradle'
- name: Authenticate to GCP
uses: google-github-actions/auth@v3
with:
token_format: access_token
workload_identity_provider: 'projects/1038484894585/locations/global/workloadIdentityPools/github-wi-pool/providers/github-wi-provider'
service_account: 'dsp-artifact-registry-push@dsp-artifact-registry.iam.gserviceaccount.com'
- name: Test with coverage
run: ./gradlew --build-cache test jacocoTestReport --scan
- name: SonarQube scan for library
Expand Down
4 changes: 2 additions & 2 deletions buildSrc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ repositories {
dependencies {
implementation 'com.diffplug.spotless:spotless-plugin-gradle:8.4.0'
implementation 'com.srcclr.gradle:com.srcclr.gradle.gradle.plugin:3.1.12'
implementation 'org.sonarqube:org.sonarqube.gradle.plugin:4.4.1.3373'
implementation 'org.sonarqube:org.sonarqube.gradle.plugin:5.1.0.4882'
implementation 'info.picocli:picocli:4.7.7'
implementation 'com.gorylenko.gradle-git-properties:gradle-git-properties:2.4.1'
implementation 'com.gorylenko.gradle-git-properties:gradle-git-properties:2.5.7'
implementation 'org.jfrog.buildinfo:build-info-extractor-gradle:6.0.4'
}
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {

boolean isCiServer = System.getenv().containsKey("CI")
ext {
junit_version = '5.10.0'
junit_version = '5.14.3'
mockito_version = '5.5.0'
}

Expand All @@ -22,9 +22,9 @@ java {
dependencies {
testImplementation 'org.hamcrest:hamcrest:2.2'

testImplementation "org.junit.jupiter:junit-jupiter-api:$junit_version"
testImplementation "org.junit.jupiter:junit-jupiter-params:$junit_version"
testRuntimeOnly "org.junit.jupiter:junit-jupiter-engine:$junit_version"
testImplementation("org.junit.jupiter:junit-jupiter:$junit_version")
testRuntimeOnly("org.junit.platform:junit-platform-launcher")

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle 9 was failing to find all the junit libraries; updated the dependency tree appropriately.

testImplementation "org.mockito:mockito-core:$mockito_version"
testImplementation "org.mockito:mockito-junit-jupiter:$mockito_version"
}
Expand Down
2 changes: 1 addition & 1 deletion cli/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ application {
mainClass = 'bio.terra.pfb.JavaPfbCommand'
}

version gradle.releaseVersion
version = gradle.releaseVersion
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses a syntax deprecation warning in the newer gradle.

apply from: "generators.gradle"

repositories {
Expand Down
Binary file modified gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
2 changes: 1 addition & 1 deletion gradle/wrapper/gradle-wrapper.properties
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.3-bin.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-9.4.1-bin.zip
networkTimeout=10000
validateDistributionUrl=true
zipStoreBase=GRADLE_USER_HOME
Expand Down
28 changes: 14 additions & 14 deletions gradlew

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 13 additions & 12 deletions gradlew.bat

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions library/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -4,17 +4,17 @@ plugins {
id 'bio.terra.pfb.java-library-conventions'
id 'com.github.davidmc24.gradle.plugin.avro' version '1.9.1'
id 'me.champeau.jmh' version '0.7.3'
id 'com.google.cloud.artifactregistry.gradle-plugin' version '2.1.5'
id 'com.google.cloud.artifactregistry.gradle-plugin' version '2.2.5'
}

repositories {
maven {
// Terra proxy for maven central
url 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/maven-central/'
url = 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/maven-central/'
}
mavenCentral()
maven {
url 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-release/'
url = 'https://us-central1-maven.pkg.dev/dsp-artifact-registry/libs-release/'
Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addresses a syntax deprecation warning in the newer gradle.

}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@
import java.nio.file.Paths;
import java.util.List;
import org.skyscreamer.jsonassert.JSONAssert;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

public class CompareOutputUtils {
private static final Logger logger = LoggerFactory.getLogger(CompareOutputUtils.class);

public static void assertJavaPfbIsPyPFB(
String fileName, PfbCommandType commandType, String filePath, FileExtension fileExtension)
Expand Down
Loading