fix: Caches slack events in order to prevent resends firing#104
Merged
BigSpaceships merged 32 commits intomainfrom May 3, 2026
Merged
fix: Caches slack events in order to prevent resends firing#104BigSpaceships merged 32 commits intomainfrom
BigSpaceships merged 32 commits intomainfrom
Conversation
tests: Slack Coverage
Weather dev
docs: Updated README.md
fix: Slack immediately responds
feat: Caches Slack Events
fix: await await await await await await await await await
fix: Body argument in the wrong position
fix: await squared
fix: actually return the correct thing
fix: Adds correct event has (im too tired)
fix: Slack lies to you, and it lied to me too
BigSpaceships
requested changes
May 2, 2026
BigSpaceships
left a comment
BigSpaceships
left a comment
There was a problem hiding this comment.
overall fire, just two little things
fix: Removes conflicting check
feat: Implements Slack Signing
fix: Fixes load to loads
fix: Stops Form swallowing Stream
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
what the PR changes
This PR adds a cache using the Slack event ids and trigger ids as a hash.
Why
why these changes were made
These changes were made in order to stop jumpstart sending two requests per announcement, along with adding a failsafe if slack throttles
Test Plan
how did you verify these changes did what you expected
Rerouted the jumpstart bot to the dev branch, to verify that all slack actions worked
Env Vars
did you add, remove, or rename any environment variables
No
Documentation
did you add or update any documentation. PRs should, at the minimum, update documentation when they make existing documentation out of date.
Documentation was added directly in the code, however /docs has not been updated
Checklist