asahi: Improve VM bind performance for large BOs#495
Open
TrungNguyen1909 wants to merge 1 commit intoAsahiLinux:asahifrom
Open
asahi: Improve VM bind performance for large BOs#495TrungNguyen1909 wants to merge 1 commit intoAsahiLinux:asahifrom
TrungNguyen1909 wants to merge 1 commit intoAsahiLinux:asahifrom
Conversation
Signed-off-by: Hoang Trung Nguyen <trung@kryptoslogic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large BOs can take quite long time to randomly-map/bind to AGX address space since the current implementation iterates through every page entries that come before the requested BO offset.
This pull request provides an improvement by caching up all the SGT entries (linked list) into an
KVVecandbinary_search()on it. The additional memory-usage is3*8*NENTSbytes perVmBoallocation (i.e Asahi VM x mapped).SGTable's Rust implementation currently do not exportsg_nentsso the allocation here is likeO(NlogN)(can be reduced in the next version).The cost for the first bind remains about the same but if we are doing bind/unbind from a large BO repeatedly then the cost for the sequential binds are greatly reduced, amortizing the initial cost.
A few questions that need to be addressed:
If we are doing this on all BOs, should we drop theCannot be done since SGTable is owning the pages.SGTablein theVmBostructure?sg_vecif the entries are physically contiguous.