fix(container): harden shell terminal keybinds for Docker-attached panes#81
Merged
AnExiledDev merged 2 commits intostagingfrom Apr 29, 2026
Merged
fix(container): harden shell terminal keybinds for Docker-attached panes#81AnExiledDev merged 2 commits intostagingfrom
AnExiledDev merged 2 commits intostagingfrom
Conversation
Disable signals that cause problems in Docker-attached terminals: Ctrl+Z (suspend closes pane), Ctrl+S/Q (flow control freeze), Ctrl+W (Windows Terminal close-tab conflict). Rebind SIGQUIT and EOF to esoteric combos for emergency use.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Alt+W (copy-region-as-kill) and Alt+Q (push-line) are unused emacs line-editor operations that occupy useful Alt key slots. Removed alongside the existing Ctrl key hardening.
This was referenced Apr 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ctrl+Z(suspend, closes Docker-attached panes),Ctrl+S/Q(flow control freeze),Ctrl+W(conflicts with Windows Terminal close-tab)Ctrl+\→Ctrl+]andCtrl+D→Ctrl+^as emergency-only alternativesbindkey -rto remove zsh line-editor bindings that bypass stty:Ctrl+W(backward-kill-word),Alt+W(copy-region-as-kill),Alt+Q(push-line)All config lives in the managed block in
setup-aliases.sh— idempotent, rewritten on every container start.Test plan
docker exec)stty -a— verifysusp = <undef>,werase = <undef>,quit = ^\],eof = ^\^, noixonCtrl+Z— nothing should happenCtrl+S— terminal should NOT freezeCtrl+W— should NOT delete a wordAlt+W— nothing should happen (zsh)Alt+Q— nothing should happen (zsh)Ctrl+^— sends EOF (incat, terminates input)Ctrl+]— sends SIGQUIT (incat, shows^\)Ctrl+Cstill works (SIGINT unaffected)