fix: Enable signed requantized max pooling with differing qinfo#1286
Open
fix: Enable signed requantized max pooling with differing qinfo#1286
Conversation
Enable QASYMM8_SIGNED NHWC MAX pooling with differing input/output quantization info in the asm wrapper. Fix the A64/SVE2/SME signed requantized max pooling kernels to apply input and output offsets correctly, and add NEON pooling validation and execution coverage for the supported signed padded MAX cases. Keep AVG pooling unchanged and leave SME2 on the existing guarded path. Signed-off-by: Pablo Marquez Tello <pablo.tello@arm.com> Change-Id: I6105404638ce11e32ec3a1275eea26e0b795b98a
Contributor
|
Is this really a fix? Sounds like a |
gunes-arm
requested changes
May 1, 2026
Contributor
gunes-arm
left a comment
gunes-arm
left a comment
There was a problem hiding this comment.
I've made one comment re. the commit title (and please change the Pr, too)
Also, this one:
Keep AVG pooling unchanged and leave SME2 on the existing guarded path.
I think this should be SME, not SME2. Nit pick :)
As long as someone looks at the assembly code, I'm ok with the rest of the changes and the tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable QASYMM8_SIGNED NHWC MAX pooling with differing input/output quantization info in the asm wrapper.
Fix the A64/SVE2/SME signed requantized max pooling kernels to apply input and output offsets correctly, and add NEON pooling validation and execution coverage for the supported signed padded MAX cases.
Keep AVG pooling unchanged and leave SME2 on the existing guarded path.
Change-Id: I6105404638ce11e32ec3a1275eea26e0b795b98a