perf: Raise Model does not exist instead of a null pointer exception#5183
perf: Raise Model does not exist instead of a null pointer exception#5183wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
Model does not exist instead of a null pointer exception#5183Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
| if temp_len > max_paragraph_char_number: | ||
| row_data = content[0:max_paragraph_char_number - temp_len] | ||
| data_list.append(f"<data>{row_data}</data>") | ||
| break |
There was a problem hiding this comment.
顺便优化：减少内存的使用。
| raise AppApiException(500, _('Model does not exist')) | ||
| if model is None: | ||
| raise AppApiException(500, _('Model does not exist')) | ||
| return {'id': str(model.id), 'provider': model.provider, 'name': model.name, 'model_type': model.model_type, |
There was a problem hiding this comment.
移到 if 外面，否则 model.id 报空指针，抛出 Model does not exist 更合理
wangliang181230
force-pushed
the
PR/fix-NPE
branch
from
6efc90c to
47faed2
Compare
1 participant
What this PR does / why we need it?
perf: Raise
Model does not existinstead of a null pointer exceptionSummary of your change
优化：抛出
模型不能为空的异常，而不是空指针异常Please indicate you've done the following: