fix: Fix the . dot in the regex not matching \n#5179
Open
wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
Open
fix: Fix the . dot in the regex not matching \n#5179wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
. dot in the regex not matching \n#5179wangliang181230 wants to merge 1 commit into1Panel-dev:v2from
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
3 tasks
wangliang181230
force-pushed
the
PR/fix-DOTALL2
branch
4 times, most recently
from
8348016 to
659e9d4
Compare
wangliang181230
force-pushed
the
PR/fix-DOTALL2
branch
from
35ab517 to
99f612e
Compare
wangliang181230
commented
Apr 30, 2026
| if application_node.get('runtime_node_id') == runtime_node_id: | ||
| content: str = application_node.get('content') | ||
| match = re.search('<form_rander>.*?</form_rander>', content) | ||
| match = re.search(r'<form_rander>.*?<\/form_rander>', content, flags=re.DOTALL) |
wangliang181230
commented
Apr 30, 2026
| form_setting['form_data'] = node_data | ||
| value = f'<form_rander>{json.dumps(form_setting)}</form_rander>' | ||
| res = re.sub('<form_rander>.*?</form_rander>', | ||
| '${value}', content) |
wangliang181230
commented
Apr 30, 2026
| # print(f"problem: {problem}") | ||
| problem = re.sub(r"^\d+\.\s*", "", problem) | ||
| pattern = r"<question>(.*?)</question>" | ||
| match = re.search(pattern, problem) |
wangliang181230
commented
Apr 30, 2026
| text = re.sub(r'\s+', ' ', text) | ||
| # 去除表单渲染 | ||
| re.sub(r'<form_rander>[\s\S]*?<\/form_rander>', '', text) | ||
| text = re.sub(r'<form_rander>.*?<\/form_rander>', '', text, flags=re.DOTALL) |
Contributor
Author
There was a problem hiding this comment.
修复4：遗漏了 text = ，导致实际上并未去除表单渲染
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
fix: Fix the
.dot in the regex not matching\nSummary of your change
解决正则中的
.点，未匹配换行符的问题（总共3处该问题和1处另一问题，其他为写法转换）Please indicate you've done the following: