From e670406eff2eaab75cc3cc13991cd9bd2bf7ca28 Mon Sep 17 00:00:00 2001 From: Neikon Date: Mon, 4 May 2026 16:34:11 +0000 Subject: [PATCH] fix: tolerate closed issue state casing --- .github/workflows/close-merged-theme-submission.yml | 2 +- MEMORY.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/close-merged-theme-submission.yml b/.github/workflows/close-merged-theme-submission.yml index db2f211..7e39753 100644 --- a/.github/workflows/close-merged-theme-submission.yml +++ b/.github/workflows/close-merged-theme-submission.yml @@ -29,7 +29,7 @@ jobs: issue_state="$(gh issue view "$issue_number" --json state --jq .state)" - if [ "$issue_state" = "CLOSED" ]; then + if [ "$issue_state" = "CLOSED" ] || [ "$issue_state" = "closed" ]; then echo "Source issue #${issue_number} is already closed." exit 0 fi diff --git a/MEMORY.md b/MEMORY.md index a594b27..de6a817 100644 --- a/MEMORY.md +++ b/MEMORY.md @@ -45,7 +45,7 @@ This file stores durable project context so future conversations can resume work - Theme submission automation uses GitHub Issue Forms plus `.github/workflows/create-theme-submission.yml`; it creates candidate PRs from complete submission issues without Decap or external auth hosting - Approved submission PRs are finalized by `.github/workflows/publish-approved-theme-submission.yml`, which sets `status: "published"` and assigns the next available low `catalogIndex`; maintainers still merge the PR explicitly - Merged submission PRs close their source issue through `.github/workflows/close-merged-theme-submission.yml`; new generated PR bodies also include `Closes #` -- The close-merged submission workflow became idempotent on 2026-05-03: it now exits successfully when the source issue was already closed by GitHub's `Closes #` automation. +- The close-merged submission workflow became idempotent on 2026-05-03 and was hardened on 2026-05-04: it now exits successfully when the source issue was already closed by GitHub's `Closes #` automation, accepting both uppercase and lowercase issue state values from `gh`. - `.github/workflows/refresh-theme-stats.yml` runs monthly and opens a PR for changed repository stars, update dates, owner avatars, or accessibility values - The build workflow syntax also requires `workflow_dispatch:` with a trailing colon; missing it makes GitHub mark the workflow file as invalid even if other checks still pass